Commit Graph

50 Commits

Author SHA1 Message Date
Hargobind S. Khalsa
2878de5b26 Validate the query hash before persisting queries 2020-10-31 13:53:53 -07:00
Koxiaet
12fe7445c7 Replace futures with futures_util 2020-10-16 07:49:22 +01:00
Koxiaet
ec8ec740be Avoid locking extensions mutex when possible 2020-10-16 06:52:52 +01:00
Koxiaet
7c604c0c7c Rustfmt 2020-10-15 07:39:53 +01:00
Koxiaet
93c886af07 Make imports consistent 2020-10-15 07:38:10 +01:00
Sunli
25af42ed81 Improve performance 2020-10-12 14:49:32 +08:00
Sunli
c777150dcd Use value! instead of serde_json::json!. 2020-10-12 10:17:05 +08:00
Sunli
e056edbaa0 Add parse_value and from_value funcntions. 2020-10-11 20:24:31 +08:00
Sunli
87ba51fdd0 Some improvements. 2020-10-10 16:28:07 +08:00
Sunli
03deffe607 Merge master 2020-10-01 09:40:04 +08:00
Sunli
6afac75ccf Merge branch 'master' into rework-errors 2020-10-01 09:39:47 +08:00
Koxiaet
4b20a21783 Fix compilation and tests 2020-09-30 19:40:17 +01:00
Koxiaet
768b666acd Merge master 2020-09-30 18:24:24 +01:00
Sunli
a95a532857 Added Apollo persisted queries extension. #280 2020-09-30 11:37:12 +08:00
Koxiaet
50009b66ce Rework errors
This completely overhauls the error system used in async-graphql.
- `Error` has been renamed to `ServerError` and `FieldError` has been
renamed to just `Error`. This is because `FieldError` is by far the most
common error that users will have to use so it makes sense to use the
most obvious error name. Also, the current name didn't make sense as it
was used for things other than field errors, such as the data callback
for websockets.
- `ServerError` has been made completely opaque. Before it was an enum
of all the possible errors, but now it just contains an error message,
the locations, the path and extensions. It is a shame that we lose
information, it makes more sense as _conceptually_ GraphQL does not
provide that information. It also frees us to change the internals of
async-graphql a lot more.
- The path of errors is no longer an opaque JSON value but a regular
type, `Vec<PathSegment>`. The type duplication of `PathSegment` and
`QueryPathSegment` is unfortunate, I plan to work on this in the future.
- Now that `ServerError` is opaque, `RuleError` has been removed from
the public API, making it simpler.
- Additionally `QueryError` has been completely removed. Instead the
error messages are constructed ad-hoc; I took care to never repeat an
error message.
- Instead of constructing field-not-found errors inside the
implementations of field resolvers they now return `Option`s, where a
`None` value is representative of the field not being found.
- As an unfortunate consequence of the last change, self-referential
types based on the output of a subscription resolver can no longer be
created. This does not mean anything for users, but causes lifetime
issues in the implementation of merged objects. I fixed it with a bit of
a hack, but this'll have to be looked into further.
- `InputValueError` now has a generic parameter - it's kind of weird but
it's necessary for ergonomics. It also improves error messages.
- The `ErrorExtensions` trait has been removed. I didn't think the
`extend` method was necessary since `From` impls exist. But the
ergonomics are still there with a new trait `ExtendError`, which
is implemented for both errors and results.
- `Response` now supports serializing multiple errors. This allows for
nice things like having multiple validation errors not be awkwardly
shoved into a single error.
- When an error occurs in execution, data is sent as `null`. This is
slightly more compliant with the spec but the algorithm described in
<https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has
yet to be implemented.
2020-09-29 20:06:44 +01:00
Sunli
4e7bb1a59c Added context for Extension. 2020-09-29 20:47:37 +08:00
Sunli
b47d08c5b5 Invoke extensions for execute_schema. 2020-09-26 15:52:59 +08:00
Sunli
5c293ffdc2 Improve the error message of Tracing extension. 2020-09-26 12:35:28 +08:00
Sunli
c350d182ce When an error occurs in the query, the Tracing extension can output the error message. 2020-09-26 09:49:46 +08:00
Sunli
3e19b23178 Remove unnecessary features for tide and warp integrations. 2020-09-26 08:35:17 +08:00
Sunli
5eef10a1c4 Make uuid to optional dependent. 2020-09-25 15:40:04 +08:00
Sunli
b316c30416 Add data_XXX methods to ResolveInfo and remove context field from ResolveInfo. #260 2020-09-25 15:26:29 +08:00
Sunli
8a82954f0b Improve tracing 2020-09-25 15:01:55 +08:00
Koxiaet
49462cf05f Move some validations to parser
This commit moves the single anonymous and duplicated operation name
validation rules into the parser, allowing for a nicer format to be
exposed by it. It also adds better error messages to the parser.
2020-09-22 19:59:48 +01:00
Koxiaet
e2f53cc30f Document features 2020-09-15 19:32:13 +01:00
Koxiaet
a3ad1aac30 Remove and feature-gate dependencies 2020-09-14 19:38:41 +01:00
Sunli
c397156657 Merge branch 'master' of https://github.com/async-graphql/async-graphql 2020-09-09 18:42:58 +08:00
Sunli
a4a5847d4f Add context to ResolveInfo. #260 2020-09-09 18:42:10 +08:00
Koxiaet
47259548c4 Support service parsing in async-graphql-parser
- Instead of adding a separate module `schema` like there was before,
since service parsing and executable parsing have a fair amount of
overlap I put them as two submodules `executable` and `service` in both
`parse` and `types`. Also, the grammar is unified under one `.pest`
file.
- Added const equivalents to `Value`, `Directive` etc
- Change the reexport `async_graphql::Value` from
`async_graphql_parser::types::Value` to
`async_graphql_parser::types::ConstValue` since in 99% of cases in this library
a const value is wanted instead of a value.
- Added consistent usage of executable/service instead of the ambiguous
query/schema.
- Some of the tests actually had invalid GraphQL so the new more correct
grammar made them fail, that was fixed.
- Added a `Name` newtype to refer to GraphQL names
(`[A-Za-z_][A-Za-z_0-9]*`) since they are used so frequently.
2020-09-08 09:21:27 +01:00
Koxiaet
c055736101 Rustfmt 2020-09-06 07:16:36 +01:00
Koxiaet
81d85c2535 Rewrite async-graphql-parser 2020-09-06 06:38:31 +01:00
Koxiaet
02f7a5fbbc Remove dependency on serde_derive, satisfy Clippy, improve docs 2020-08-31 19:18:02 +01:00
Sunli
0c4f8e5c16 Clippy clean 2020-08-31 15:40:44 +08:00
Sunli
78d3885a67 Cargo fmt --all 2020-08-31 15:35:53 +08:00
D1plo1d
7f7397650a Added async_graphql::graphql tracing namespace 2020-08-30 21:11:43 -04:00
D1plo1d
5a6c77ba9d Refactored tracing extension to allow better span and event filtering and improve signal to noise 2020-08-30 21:01:53 -04:00
D1plo1d
c675b929d3 Added Default to tracing extension 2020-08-30 16:32:14 -04:00
Sunli
a2aa731fe4 Use log crate instead of xlog because xlog still needs to be perfected. #217 2020-07-24 16:55:46 +08:00
Sunli
4d3851e1b5 Replace log crate with xlog. 2020-07-15 18:05:24 +08:00
Sunli
7630fe1f51 Extension::Logger now provides more comprehensive error information. 2020-06-13 22:14:47 +08:00
sunli
1069461873 Logger extensions filter out introspection. #87 2020-05-27 20:47:22 +08:00
Sunli
1461210df7 Add logger extension 2020-05-22 11:58:49 +08:00
sunli
6f924efcf4 Add defer tests 2020-05-20 13:42:55 +08:00
sunli
8faa376776 Add tracing extension 2020-04-28 15:01:19 +08:00
sunli
740804e327 Extension::result now returns an Option 2020-04-24 10:37:18 +08:00
sunli
0b6bfd4c33 Add GQLHttpRequest and IntoQueryBuilder trait 2020-04-11 17:36:05 +08:00
sunli
14860d9b88 Reimplement the error type and remove the dependency on the anyhow::Error 2020-04-02 10:21:04 +08:00
sunli
a13204273e v1.6.8
Add context data support
2020-03-31 11:19:18 +08:00
sunli
fb1fef022b v1.6.2 2020-03-26 18:30:29 +08:00
sunli
bc0d6603c1 v1.6.0 2020-03-26 11:34:28 +08:00