Commit Graph

10 Commits

Author SHA1 Message Date
Sunli 548655ee71 Update tests 2022-04-19 11:06:54 +08:00
Sunli dbc0862894 Rework Failure 3 #671 2021-11-07 19:11:43 +08:00
Sunli 369f1459b7 Rework Failure #671 2021-11-04 19:37:22 +08:00
Sunli 1385199107 Fix tests 2021-11-04 14:54:26 +08:00
Sunli 412f78211f Update test 2021-06-08 19:04:06 +08:00
Sunli e7382bf549 Rework error propagation. #531 2021-06-08 10:05:30 +08:00
Sunli 59ee28b634 Update tests 2021-06-07 14:12:28 +08:00
Sunli 572f907df7 Now when the resolver returns the `Result` type, `E` can be all types that implement `Into<async_graphql::Error>`. 2021-04-09 15:04:01 +08:00
Sunli 4f47703118 Switch the async runtime used for testing to Tokio. 2021-03-12 12:47:24 +08:00
Koxiaet 50009b66ce Rework errors
This completely overhauls the error system used in async-graphql.
- `Error` has been renamed to `ServerError` and `FieldError` has been
renamed to just `Error`. This is because `FieldError` is by far the most
common error that users will have to use so it makes sense to use the
most obvious error name. Also, the current name didn't make sense as it
was used for things other than field errors, such as the data callback
for websockets.
- `ServerError` has been made completely opaque. Before it was an enum
of all the possible errors, but now it just contains an error message,
the locations, the path and extensions. It is a shame that we lose
information, it makes more sense as _conceptually_ GraphQL does not
provide that information. It also frees us to change the internals of
async-graphql a lot more.
- The path of errors is no longer an opaque JSON value but a regular
type, `Vec<PathSegment>`. The type duplication of `PathSegment` and
`QueryPathSegment` is unfortunate, I plan to work on this in the future.
- Now that `ServerError` is opaque, `RuleError` has been removed from
the public API, making it simpler.
- Additionally `QueryError` has been completely removed. Instead the
error messages are constructed ad-hoc; I took care to never repeat an
error message.
- Instead of constructing field-not-found errors inside the
implementations of field resolvers they now return `Option`s, where a
`None` value is representative of the field not being found.
- As an unfortunate consequence of the last change, self-referential
types based on the output of a subscription resolver can no longer be
created. This does not mean anything for users, but causes lifetime
issues in the implementation of merged objects. I fixed it with a bit of
a hack, but this'll have to be looked into further.
- `InputValueError` now has a generic parameter - it's kind of weird but
it's necessary for ergonomics. It also improves error messages.
- The `ErrorExtensions` trait has been removed. I didn't think the
`extend` method was necessary since `From` impls exist. But the
ergonomics are still there with a new trait `ExtendError`, which
is implemented for both errors and results.
- `Response` now supports serializing multiple errors. This allows for
nice things like having multiple validation errors not be awkwardly
shoved into a single error.
- When an error occurs in execution, data is sent as `null`. This is
slightly more compliant with the spec but the algorithm described in
<https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has
yet to be implemented.
2020-09-29 20:06:44 +01:00