anna/async-graphql
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prefer TryFrom to TryInto for ID

Browse Source
This commit is contained in:
Samuel Hurel 2020-05-10 16:13:41 +02:00
parent e3542a1360
commit 0344b0b996
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/scalars/id.rs
View File

@ -1,7 +1,7 @@
use crate::{InputValueError, InputValueResult, Result, ScalarType, Value};
use async_graphql_derive::Scalar;
use bson::oid::{self, ObjectId};
use std::convert::TryInto;
use std::convert::TryFrom;
use std::num::ParseIntError;
use std::ops::{Deref, DerefMut};
use uuid::Uuid;
@ -41,27 +41,27 @@ impl Into<String> for ID {
}
}
impl TryInto<usize> for ID {
impl TryFrom<ID> for usize {
type Error = ParseIntError;
fn try_into(self) -> std::result::Result<usize, Self::Error> {
self.0.parse()
fn try_from(id: ID) -> std::result::Result<Self, Self::Error> {
id.0.parse()
}
}
impl TryInto<Uuid> for ID {
impl TryFrom<ID> for Uuid {
type Error = uuid::Error;
fn try_into(self) -> std::result::Result<Uuid, Self::Error> {
Uuid::parse_str(&self.0)
fn try_from(id: ID) -> std::result::Result<Self, Self::Error> {
Uuid::parse_str(&id.0)
}
}
impl TryInto<ObjectId> for ID {
impl TryFrom<ID> for ObjectId {
type Error = oid::Error;
fn try_into(self) -> std::result::Result<ObjectId, oid::Error> {
ObjectId::with_string(&self.0)
fn try_from(id: ID) -> std::result::Result<Self, oid::Error> {
ObjectId::with_string(&id.0)
}
}