async-graphql/tests/subscription.rs

427 lines
10 KiB
Rust
Raw Normal View History

2020-04-06 10:30:38 +00:00
use async_graphql::*;
2020-09-10 11:35:48 +00:00
use futures::{Stream, StreamExt, TryStreamExt};
2020-04-06 10:30:38 +00:00
#[async_std::test]
pub async fn test_subscription() {
struct QueryRoot;
#[derive(SimpleObject)]
2020-04-06 10:30:38 +00:00
struct Event {
a: i32,
b: i32,
}
#[Object]
2020-04-06 10:30:38 +00:00
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
2020-04-06 10:30:38 +00:00
impl SubscriptionRoot {
2020-04-07 06:30:46 +00:00
async fn values(&self, start: i32, end: i32) -> impl Stream<Item = i32> {
2020-04-06 10:30:38 +00:00
futures::stream::iter(start..end)
}
2020-04-07 06:30:46 +00:00
async fn events(&self, start: i32, end: i32) -> impl Stream<Item = Event> {
2020-04-06 10:30:38 +00:00
futures::stream::iter((start..end).map(|n| Event { a: n, b: n * 10 }))
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
{
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream("subscription { values(start: 10, end: 20) }")
2020-09-11 07:54:56 +00:00
.map(|resp| resp.into_result().unwrap().data)
.boxed();
2020-04-06 10:30:38 +00:00
for i in 10..20 {
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "values": i })),
2020-04-06 10:30:38 +00:00
stream.next().await
);
}
assert!(stream.next().await.is_none());
}
{
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream("subscription { events(start: 10, end: 20) { a b } }")
2020-09-11 07:54:56 +00:00
.map(|resp| resp.into_result().unwrap().data)
.boxed();
2020-04-06 10:30:38 +00:00
for i in 10..20 {
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "events": {"a": i, "b": i * 10} })),
2020-04-06 10:30:38 +00:00
stream.next().await
);
}
assert!(stream.next().await.is_none());
}
}
2020-04-08 01:05:54 +00:00
#[async_std::test]
pub async fn test_subscription_with_ctx_data() {
struct QueryRoot;
#[Object]
impl QueryRoot {}
2020-04-23 14:29:38 +00:00
struct MyObject;
#[Object]
2020-04-23 14:29:38 +00:00
impl MyObject {
async fn value(&self, ctx: &Context<'_>) -> i32 {
*ctx.data_unchecked::<i32>()
2020-04-23 14:29:38 +00:00
}
}
struct SubscriptionRoot;
#[Subscription]
impl SubscriptionRoot {
async fn values(&self, ctx: &Context<'_>) -> impl Stream<Item = i32> {
let value = *ctx.data_unchecked::<i32>();
futures::stream::once(async move { value })
}
2020-04-23 14:29:38 +00:00
async fn objects(&self) -> impl Stream<Item = MyObject> {
futures::stream::once(async move { MyObject })
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
{
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream(Request::new("subscription { values objects { value } }").data(100i32))
2020-09-11 07:54:56 +00:00
.map(|resp| resp.data)
.boxed();
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "values": 100 })),
stream.next().await
);
2020-04-23 14:29:38 +00:00
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "objects": { "value": 100 } })),
2020-04-23 14:29:38 +00:00
stream.next().await
);
assert!(stream.next().await.is_none());
}
}
#[async_std::test]
pub async fn test_subscription_with_token() {
struct QueryRoot;
#[Object]
impl QueryRoot {}
struct SubscriptionRoot;
struct Token(String);
#[Subscription]
impl SubscriptionRoot {
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
async fn values(&self, ctx: &Context<'_>) -> Result<impl Stream<Item = i32>> {
if ctx.data_unchecked::<Token>().0 != "123456" {
return Err("forbidden".into());
}
Ok(futures::stream::once(async move { 100 }))
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
{
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream(
Request::new("subscription { values }").data(Token("123456".to_string())),
)
2020-09-11 07:54:56 +00:00
.map(|resp| resp.into_result().unwrap().data)
.boxed();
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "values": 100 })),
stream.next().await
);
assert!(stream.next().await.is_none());
}
{
assert!(schema
2020-09-10 11:35:48 +00:00
.execute_stream(
Request::new("subscription { values }").data(Token("654321".to_string()))
)
2020-09-11 07:54:56 +00:00
.boxed()
.next()
.await
.unwrap()
.is_err());
}
}
2020-05-03 01:12:14 +00:00
#[async_std::test]
pub async fn test_subscription_inline_fragment() {
struct QueryRoot;
#[derive(SimpleObject)]
2020-05-03 01:12:14 +00:00
struct Event {
a: i32,
b: i32,
}
#[Object]
2020-05-03 01:12:14 +00:00
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
2020-05-03 01:12:14 +00:00
impl SubscriptionRoot {
async fn events(&self, start: i32, end: i32) -> impl Stream<Item = Event> {
futures::stream::iter((start..end).map(|n| Event { a: n, b: n * 10 }))
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream(
2020-05-03 01:12:14 +00:00
r#"
subscription {
events(start: 10, end: 20) {
a
... {
b
}
}
}
"#,
)
2020-09-11 07:54:56 +00:00
.map(|resp| resp.data)
.boxed();
2020-05-03 01:12:14 +00:00
for i in 10..20 {
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "events": {"a": i, "b": i * 10} })),
2020-05-03 01:12:14 +00:00
stream.next().await
);
}
assert!(stream.next().await.is_none());
}
#[async_std::test]
pub async fn test_subscription_fragment() {
struct QueryRoot;
#[derive(SimpleObject)]
2020-05-03 01:12:14 +00:00
struct Event {
a: i32,
b: i32,
}
#[derive(Interface)]
#[graphql(field(name = "a", type = "&i32"))]
2020-05-11 03:25:49 +00:00
enum MyInterface {
Event(Event),
}
2020-05-03 01:12:14 +00:00
#[Object]
2020-05-03 01:12:14 +00:00
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
2020-05-03 01:12:14 +00:00
impl SubscriptionRoot {
async fn events(&self, start: i32, end: i32) -> impl Stream<Item = Event> {
futures::stream::iter((start..end).map(|n| Event { a: n, b: n * 10 }))
}
}
let schema = Schema::build(QueryRoot, EmptyMutation, SubscriptionRoot)
.register_type::<MyInterface>()
.finish();
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream(
2020-05-03 01:12:14 +00:00
r#"
subscription s {
events(start: 10, end: 20) {
... on MyInterface {
a
}
b
}
}
"#,
)
2020-09-11 07:54:56 +00:00
.map(|resp| resp.data)
.boxed();
for i in 10i32..20 {
2020-05-03 01:12:14 +00:00
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "events": {"a": i, "b": i * 10} })),
2020-05-03 01:12:14 +00:00
stream.next().await
);
}
assert!(stream.next().await.is_none());
}
#[async_std::test]
pub async fn test_subscription_fragment2() {
struct QueryRoot;
#[derive(SimpleObject)]
struct Event {
a: i32,
b: i32,
}
#[derive(Interface)]
#[graphql(field(name = "a", type = "&i32"))]
2020-05-11 03:25:49 +00:00
enum MyInterface {
Event(Event),
}
#[Object]
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
impl SubscriptionRoot {
async fn events(&self, start: i32, end: i32) -> impl Stream<Item = Event> {
futures::stream::iter((start..end).map(|n| Event { a: n, b: n * 10 }))
}
}
let schema = Schema::build(QueryRoot, EmptyMutation, SubscriptionRoot)
.register_type::<MyInterface>()
.finish();
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream(
r#"
subscription s {
events(start: 10, end: 20) {
... Frag
}
}
fragment Frag on Event {
a b
}
"#,
)
2020-09-11 07:54:56 +00:00
.map(|resp| resp.data)
.boxed();
for i in 10..20 {
assert_eq!(
2020-09-10 11:35:48 +00:00
Some(serde_json::json!({ "events": {"a": i, "b": i * 10} })),
stream.next().await
);
}
assert!(stream.next().await.is_none());
}
#[async_std::test]
pub async fn test_subscription_error() {
struct QueryRoot;
struct Event {
value: i32,
}
#[Object]
impl Event {
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
async fn value(&self) -> Result<i32> {
if self.value < 5 {
Ok(self.value)
} else {
Err("TestError".into())
}
}
}
#[Object]
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
impl SubscriptionRoot {
async fn events(&self) -> impl Stream<Item = Event> {
futures::stream::iter((0..10).map(|n| Event { value: n }))
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream("subscription { events { value } }")
.map(|resp| resp.into_result())
2020-09-11 07:54:56 +00:00
.map_ok(|resp| resp.data)
.boxed();
for i in 0i32..5 {
assert_eq!(
Some(Ok(serde_json::json!({ "events": { "value": i } }))),
stream.next().await
);
}
assert_eq!(
stream.next().await,
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
Some(Err(vec![ServerError {
message: "TestError".to_string(),
locations: vec![Pos {
line: 1,
column: 25
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
}],
path: vec![
PathSegment::Field("events".to_owned()),
PathSegment::Field("value".to_owned())
],
extensions: None,
}]))
);
assert!(stream.next().await.is_none());
}
2020-05-03 14:32:37 +00:00
#[async_std::test]
pub async fn test_subscription_fieldresult() {
struct QueryRoot;
#[Object]
2020-05-03 14:32:37 +00:00
impl QueryRoot {}
struct SubscriptionRoot;
#[Subscription]
2020-05-03 14:32:37 +00:00
impl SubscriptionRoot {
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
async fn values(&self) -> impl Stream<Item = Result<i32>> {
2020-05-03 14:32:37 +00:00
futures::stream::iter(0..5)
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
.map(Result::Ok)
2020-05-03 14:32:37 +00:00
.chain(futures::stream::once(
async move { Err("StreamErr".into()) },
))
}
}
let schema = Schema::new(QueryRoot, EmptyMutation, SubscriptionRoot);
let mut stream = schema
2020-09-10 11:35:48 +00:00
.execute_stream("subscription { values }")
.map(|resp| resp.into_result())
2020-09-11 07:54:56 +00:00
.map_ok(|resp| resp.data)
.boxed();
2020-05-03 14:32:37 +00:00
for i in 0i32..5 {
assert_eq!(
Some(Ok(serde_json::json!({ "values": i }))),
stream.next().await
);
}
assert_eq!(
stream.next().await,
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
Some(Err(vec![ServerError {
message: "StreamErr".to_string(),
locations: vec![Pos {
2020-05-03 14:32:37 +00:00
line: 1,
column: 16
Rework errors This completely overhauls the error system used in async-graphql. - `Error` has been renamed to `ServerError` and `FieldError` has been renamed to just `Error`. This is because `FieldError` is by far the most common error that users will have to use so it makes sense to use the most obvious error name. Also, the current name didn't make sense as it was used for things other than field errors, such as the data callback for websockets. - `ServerError` has been made completely opaque. Before it was an enum of all the possible errors, but now it just contains an error message, the locations, the path and extensions. It is a shame that we lose information, it makes more sense as _conceptually_ GraphQL does not provide that information. It also frees us to change the internals of async-graphql a lot more. - The path of errors is no longer an opaque JSON value but a regular type, `Vec<PathSegment>`. The type duplication of `PathSegment` and `QueryPathSegment` is unfortunate, I plan to work on this in the future. - Now that `ServerError` is opaque, `RuleError` has been removed from the public API, making it simpler. - Additionally `QueryError` has been completely removed. Instead the error messages are constructed ad-hoc; I took care to never repeat an error message. - Instead of constructing field-not-found errors inside the implementations of field resolvers they now return `Option`s, where a `None` value is representative of the field not being found. - As an unfortunate consequence of the last change, self-referential types based on the output of a subscription resolver can no longer be created. This does not mean anything for users, but causes lifetime issues in the implementation of merged objects. I fixed it with a bit of a hack, but this'll have to be looked into further. - `InputValueError` now has a generic parameter - it's kind of weird but it's necessary for ergonomics. It also improves error messages. - The `ErrorExtensions` trait has been removed. I didn't think the `extend` method was necessary since `From` impls exist. But the ergonomics are still there with a new trait `ExtendError`, which is implemented for both errors and results. - `Response` now supports serializing multiple errors. This allows for nice things like having multiple validation errors not be awkwardly shoved into a single error. - When an error occurs in execution, data is sent as `null`. This is slightly more compliant with the spec but the algorithm described in <https://spec.graphql.org/June2018/#sec-Errors-and-Non-Nullability> has yet to be implemented.
2020-09-29 19:06:44 +00:00
}],
path: vec![PathSegment::Field("values".to_owned())],
extensions: None,
}]))
2020-05-03 14:32:37 +00:00
);
assert!(stream.next().await.is_none());
}