From 92716a21864bf14ee60a543bd82004c17b8418d9 Mon Sep 17 00:00:00 2001 From: Aurelien Foucault Date: Sat, 3 Oct 2020 23:52:23 +0200 Subject: [PATCH] Clippy --- derive/src/utils.rs | 4 ++-- src/guard.rs | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/derive/src/utils.rs b/derive/src/utils.rs index 0fdbeb77..796a9307 100644 --- a/derive/src/utils.rs +++ b/derive/src/utils.rs @@ -136,9 +136,9 @@ pub fn generate_guards( .into()); } if let NestedMeta::Meta(rule) = &args.nested[0] { - return generate_guards(crate_name, rule); + generate_guards(crate_name, rule) } else { - return Err(Error::new_spanned(&args.nested[0], "Invalid rule.").into()); + Err(Error::new_spanned(&args.nested[0], "Invalid rule.").into()) } } "and" => { diff --git a/src/guard.rs b/src/guard.rs index 16a5130b..bcc25e1e 100644 --- a/src/guard.rs +++ b/src/guard.rs @@ -35,7 +35,8 @@ pub struct And(A, B); #[async_trait::async_trait] impl Guard for And { async fn check(&self, ctx: &Context<'_>) -> Result<()> { - self.0.check(ctx).await.and(self.1.check(ctx).await) + let second_result = self.1.check(ctx).await; + self.0.check(ctx).await.and(second_result) } } @@ -45,7 +46,8 @@ pub struct Or(A, B); #[async_trait::async_trait] impl Guard for Or { async fn check(&self, ctx: &Context<'_>) -> Result<()> { - self.0.check(ctx).await.or(self.1.check(ctx).await) + let second_result = self.1.check(ctx).await; + self.0.check(ctx).await.or(second_result) } }